-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68287/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Nixon Rodrigues.


Bugs: ATLAS-2807
    https://issues.apache.org/jira/browse/ATLAS-2807


Repository: atlas


Description
-------

The current behavior - when we delete an entity f1, all tags associate to f1 
which got propagated


to downstream entities are removed – PII tag propagated to process1 and t1 is 
removed


Proposed Change


Soft Delete:


When entity f1 is deleted, retain the propagated classification edges, so the 
downstream entities


– process1 and t1 continue to have PII classification associated to them


Hard Delete:


In cases of hard delete, the source entity (f1) is deleted from atlas, but its 
classification vertex


(PII) continue to exist and will continue propagating to process1 and t1.


Diffs
-----

  common/src/main/java/org/apache/atlas/repository/Constants.java 7988d1d81 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 328b76734 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
3132379b9 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
d328873f1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 c6be4061b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 4a0924bbe 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 a95e6898e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
 41e65d4a3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 28a26ab4f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 f57ce99f7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 8f4faaff8 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 58005c458 
  
repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java
 8ceeedb01 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
e01cba92d 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fd331faa0 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
78bd53ce7 


Diff: https://reviews.apache.org/r/68287/diff/1/


Testing
-------

Validated basic cases using REST clirnt.


PreCommit: In progress


Thanks,

Sarath Subramanian

Reply via email to