----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68353/#review207282 -----------------------------------------------------------
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java Lines 153 (patched) <https://reviews.apache.org/r/68353/#comment290613> the condition is reversed here: if (executor != null) { executor.submit(.....); } else { notifyEntitiesInternal(.....); } - Sarath Subramanian On Aug. 14, 2018, 5:19 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68353/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 5:19 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, > Ramesh Mani, and Sarath Subramanian. > > > Bugs: ATLAS-2823 > https://issues.apache.org/jira/browse/ATLAS-2823 > > > Repository: atlas > > > Description > ------- > > updated hooks to support asynchronous notifications > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 77177b49f > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59 > > > Diff: https://reviews.apache.org/r/68353/diff/1/ > > > Testing > ------- > > Verified that pre-commit tests pass successfully - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/ > > > Thanks, > > Madhan Neethiraj > >
