----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68363/#review207348 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 690 (patched) <https://reviews.apache.org/r/68363/#comment290707> consider refactoring something like: boolean isIpTrusted(String requestHosts) { if (trustedProxyHosts == null) { return false; } return (trustedProxyHosts.size() == 1 && trustedProxyHosts.contains("*")) ? true : trustedProxyHosts.contains(requestHosts); } webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 701 (patched) <https://reviews.apache.org/r/68363/#comment290711> isTrustedProxyUsers => isTrustedProxyUser webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 706 (patched) <https://reviews.apache.org/r/68363/#comment290710> consider refactoring like: boolean isTrustedProxyUserGroup(List<GrantedAuthority> proxyUserGroup) { if (trustedProxyGroups == null) { return false; } if (trustedProxyGroups.size() == 1 && trustedProxyGroups.contains("*")) { return true; } else { for (GrantedAuthority group : proxyUserGroup) { if (trustedProxyGroups.contains(group.getAuthority())) { return true; } } } return false; } - Sarath Subramanian On Aug. 15, 2018, 10:26 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68363/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 10:26 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2824 > https://issues.apache.org/jira/browse/ATLAS-2824 > > > Repository: atlas > > > Description > ------- > > This patch includes code to support request from knox proxy, where the proxy > is already known and trusted to Atlas via configuration. Atlas intercepts the > incoming requests and if it from knox proxy. Atlas allow the knox's doAs user > to create session in Atlas. > > Configs required:- > > atlas.authentication.allow.trustedproxy :- property allow trusted proxy > support > atlas.proxyuser.knox.hosts :- property to add trusted hosts > atlas.proxyuser.knox.users :- property to add trusted users > atlas.proxyuser.knox.groups :- property to add trusted groups > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > e5c40d061 > webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java > 64c95203c > > > Diff: https://reviews.apache.org/r/68363/diff/1/ > > > Testing > ------- > > Tested > > * Atlas UI from Trusted Knox Proxy with Knox SSO loginpage. > * Atlas UI from Knox Proxy with Atlas Login. > * Atlas UI from Knox Proxy with SSO Filter enabled at Atlas. > * Atlas UI with Atlas Login. > * Atlas api from curl with BASIS & Kerberos headers > > > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console > > Topology Used:- > > > <topology> > <gateway> > ????????<provider> > ????????????<role>federation</role> > ????????????<name>SSOCookieProvider</name> > ????????????<enabled>true</enabled> > ????????????<param> > ????????????????<name>sso.authentication.provider.url</name> > ????????????????<value>{KNOXHOST}/gateway/knoxsso/knoxauth/login.html</value> > ????????????</param> > ????????</provider> > ????????<provider> > ????????????<role>identity-assertion</role> > ????????????<name>Default</name> > ????????????<enabled>true</enabled> > ????????</provider> > </gateway> > <service> > <role>ATLAS</role> > <url>{ATLAS_HOST}:21000/</url> > </service> > <service> > <role>ATLAS-API</role> > <url>{ATLAS_HOST}:21000</url> > </service> > </topology> > > > Thanks, > > Nixon Rodrigues > >
