[ 
https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589771#comment-16589771
 ] 

Keval Bhatt edited comment on ATLAS-2724 at 8/23/18 7:04 AM:
-------------------------------------------------------------

[~barbara] [^ATLAS-2724.patch]  this patch will support map and structs but if 
JSON object key has value as JSON-valued strings then it won't parse the value.

Regarding arrays cutoff, there is no mechanism written to check the array size 
and the cutoff accordingly because it is very hard to find the cutoff as array 
value size is not fixed.

I would say let's not do the sophisticated length check instead we go with  
[^ATLAS-2724.patch]. what would you suggest?

if the above patch will work for you then will commit this patch


was (Author: kevalbhatt18):
[~barbara] [^ATLAS-2724.patch]  this patch will support map and structs but if 
JSON object key has value as JSON-valued strings then it won't parse the value.

Regarding arrays cutoff, there is no mechanism written to check the array size 
and the cutoff accordingly because it is very hard to find the cutoff as array 
value size is not fixed.

I would say let's not do the sophisticated length check instead we go with  
[^ATLAS-2724.patch]. what would you suggest?

if the above patch will work for you the will commit this patch

> UI enhancement for Avro schemas and other JSON-valued attributes
> ----------------------------------------------------------------
>
>                 Key: ATLAS-2724
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2724
>             Project: Atlas
>          Issue Type: New Feature
>    Affects Versions: 0.8-incubating
>            Reporter: Barbara Eckman
>            Assignee: Barbara Eckman
>            Priority: Critical
>             Fix For: 0.8.3
>
>         Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, 
> ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png
>
>
> Currently JSON-valued attributes are fully displayed in-line with other 
> attributes, not pretty-printed, cluttering the display.  To support a better 
> display, we can display JSON-valued attributes in a one-line box that can be 
> scrolled down, or fully expanded with a mouse click that pretty-prints the 
> JSON. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to