----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68510/#review207938 -----------------------------------------------------------
Ship it! - Madhan Neethiraj On Aug. 25, 2018, 6:44 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68510/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2018, 6:44 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2838 > https://issues.apache.org/jira/browse/ATLAS-2838 > > > Repository: atlas > > > Description > ------- > > There are two methods to encode property key in atlas and its used > interchangeably. > > This JIRA consolidates the two encoded method to a single one from > AtlasGraphUtilsV2.encodeProperty() > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java b6b4ccd89 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > cb0cbf3c1 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > babe26782 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > ccfd3e52a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java > c34c94e00 > > > Diff: https://reviews.apache.org/r/68510/diff/1/ > > > Testing > ------- > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/611/console > > Validated that attribute with reserved character = $, #, { and } are created > with typedef > > > Thanks, > > Sarath Subramanian > >
