----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68554/#review208080 -----------------------------------------------------------
Fix it, then Ship it! Perhaps AtlasServer is a better name for AtlasService. Please review. common/src/main/java/org/apache/atlas/repository/Constants.java Line 105 (original), 105 (patched) <https://reviews.apache.org/r/68554/#comment291836> ATTR_NAME_REPLICATED_TO_CLUSTER ==> ATTR_NAME_REPLICATED_TO ATTR_NAME_REPLICATED_FROM_CLUSTER ==> ATTR_NAME_REPLICATED_FROM - Madhan Neethiraj On Aug. 29, 2018, 5:47 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68554/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2018, 5:47 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2845 > https://issues.apache.org/jira/browse/ATLAS-2845 > > > Repository: atlas > > > Description > ------- > > **Approach** > > Renamed _AtlasCluster_ to _AtlasService_. > > > Diffs > ----- > > addons/models/0010-base_model.json c6d251c79 > addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3 > common/src/main/java/org/apache/atlas/repository/Constants.java 273358360 > intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java > 320c0c723 > > repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java > ced00b948 > > repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java > 4462f2c14 > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java > a96ca497c > repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java > d417ce771 > > repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java > 6f624c3ee > > repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java > 90232b7c1 > repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json > 444103684 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 7d231252c > > webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java > d15605413 > > > Diff: https://reviews.apache.org/r/68554/diff/1/ > > > Testing > ------- > > **Unit tests** > Tests run. > > > Thanks, > > Ashutosh Mestry > >
