> On Aug. 17, 2018, 3:58 p.m., David Radley wrote: > >
Thanks David - all fixed. > On Aug. 17, 2018, 3:58 p.m., David Radley wrote: > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java > > Lines 346 (patched) > > <https://reviews.apache.org/r/68412/diff/1/?file=2074622#file2074622line346> > > > > What is the implication of leaving htis TODO in the code? I suggest at > > least there should be a Jira numebr here to track ths issue. This was a temporary solution prior to the local user id being available in the connector. This is now implemented. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68412/#review207494 ----------------------------------------------------------- On Aug. 17, 2018, 2:38 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68412/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 2:38 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-1773: Atlas OMRS Repository Connector > > > Diffs > ----- > > open-metadata/pom.xml PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java > PRE-CREATION > pom.xml c60a53b0e2e7038b6228e16ceba47a0080d58622 > webapp/pom.xml 78aa81e8046b676f47d24eff0671225a3c960929 > webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml > 23dc0637a8b521ab89a16ec8b03895cdaf8bc7d8 > > > Diff: https://reviews.apache.org/r/68412/diff/1/ > > > Testing > ------- > > Unit Testing (approx 80 tests) and Functional Testing of major operations > (creation of types, instances, reference copies and proxies). > > > Thanks, > > Graham Wallis > >
