----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68666/#review208445 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Sept. 7, 2018, 6:51 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68666/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2018, 6:51 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2827 > https://issues.apache.org/jira/browse/ATLAS-2827 > > > Repository: atlas > > > Description > ------- > > While processing requests, Atlas assigns guids for entities that have > unassigned guids in the request. When a request (from notificaiton) is > retried due to failure in earlier attempts, the retry attempt might fail due > to guid assignment performed in the earlier attempt. The fix is to reset the > guid assignments before attempting a retry. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 6e2a03fa4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 4cd9909cb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/InstanceGraphMapper.java > 8d405000b > server-api/src/main/java/org/apache/atlas/RequestContext.java 891dcc846 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 0ac3ebbf8 > > > Diff: https://reviews.apache.org/r/68666/diff/2/ > > > Testing > ------- > > Verified that retry attempts to process notifications succeed. > > > Thanks, > > Madhan Neethiraj > >
