-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68671/
-----------------------------------------------------------

(Updated Sept. 10, 2018, 4:30 p.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-2862
    https://issues.apache.org/jira/browse/ATLAS-2862


Repository: atlas


Description
-------

**Approach**
Using _RequestContextV1.earliestActiveRequestTime_.

Refactoring:
- Removed _AtlasExportData.entities_ since this had entire payload of exported 
entities, causing memory bloat.
- Changed _AtlasExport_ options' _fromTime_ to _changeToken_.
- Additional refactoring for better readability.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java 
96a6e8855 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java 
fd6871219 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java 
f066688ea 
  repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 
7fb2a3b61 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
b507002bd 
  repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java 
17ebbf13e 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 ed4fc372a 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java
 f89455318 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java
 719d6ca09 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java 
e8bbeb590 
  repository/src/test/resources/json/stocksDB-Entities/export-incremental.json 
c2bc86757 


Diff: https://reviews.apache.org/r/68671/diff/3/

Changes: https://reviews.apache.org/r/68671/diff/2-3/


Testing
-------

**Unit tests**
Existing tests.

**Volume tests**
Export with 150 tables, each with 80 columns data.

**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/657/


Thanks,

Ashutosh Mestry

Reply via email to