----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68692/#review208545 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java Lines 217 (patched) <https://reviews.apache.org/r/68692/#comment292569> ret = Objects.equals(objectId.getTypeName(), entity.getTypeName()); if (ret) { for (Map.Entry<String, Object> entry : objectId.getUniqueAttributes().entrySet()) { ret = Objects.equals(entity.getAttribute(entry.getKey()), entry.getValue()); if (!ret) { break; } } } - Madhan Neethiraj On Sept. 12, 2018, 4:41 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68692/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2018, 4:41 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2870 > https://issues.apache.org/jira/browse/ATLAS-2870 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Additional parameters to _addClassification_ transform. > - Updated _ImportTransformShaper_ to process _ExportRequest_. > > **CURL** > > curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H > "Cache-Control: no-cache" -F request=@../docs/import-options.json -F > data=@../docs/stocks-2.zip "http://localhost:21000/api/atlas/admin/import"; > > _import-options.json_ with new _addClassification_ > ``` > { > "options": { > "transforms": "{ \"Asset\": { \"*\":[ > \"addClassification:REPLICATED_2:topLevel\" ] } }", > "replicateFrom": "Cl1" > } > } > > ``` > > _import-options.json_ without the new option. > ``` > { > "options": { > "transforms": "{ \"Asset\": { \"*\":[ > \"addClassification:REPLICATED_2\" ] } }", > "replicateFrom": "Cl1" > } > } > > ``` > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > 095f60f5c > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java > 213539d59 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java > 62eba455f > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java > cd623d08a > > > Diff: https://reviews.apache.org/r/68692/diff/3/ > > > Testing > ------- > > **Unit test** > New test added. > > **Functional tests** > Verification via UI. > > > Thanks, > > Ashutosh Mestry > >
