----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68705/#review208579 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java Line 115 (original), 115 (patched) <https://reviews.apache.org/r/68705/#comment292645> attribute value is not transformed yet, consider renaming transformedValue to attributeValue - Sarath Subramanian On Sept. 12, 2018, 12:54 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68705/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2018, 12:54 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2871 > https://issues.apache.org/jira/browse/ATLAS-2871 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Move the attribute-specific transforms out of the iterator for map entries. > > **CURL** > > curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H > "Cache-Control: no-cache" -F request=@../docs/import-options.json -F > data=@../docs/hr-detailed.zip "http://localhost:21000/api/atlas/admin/import"; > > _import-options.json_ > ``` > { > "options": { > "transforms": "{ \"hdfs_path\": { \"*\":[ > \"addClassification:REPLICATED_2:topLevel\" ], \"path\": [ > \"replace:localhost:mycluster1\" ], \"qualifiedName\": [ > \"replace:localhost:mycluster1\" ], \"clusterName\": [ > \"replace:localhost:mycluster1\"], \"name\": [ > \"replace:localhost:mycluster1\"] } }", > "replicateFrom": "cl1" > } > } > > ``` > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java > 24c5d7b6e > > > Diff: https://reviews.apache.org/r/68705/diff/1/ > > > Testing > ------- > > **Unit tests** > Executed current set. > > **Functional tests** > > Via Atlas Web UI. > > > File Attachments > ---------------- > > Sample File to Import > > https://reviews.apache.org/media/uploaded/files/2018/09/12/fe340975-6c8e-427e-8145-8f7c5b22dc2b__hr-detailed.zip > > > Thanks, > > Ashutosh Mestry > >
