----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68713/#review208670 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 50 (patched) <https://reviews.apache.org/r/68713/#comment292786> key.indexOf ==> value.indexOf common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 51 (patched) <https://reviews.apache.org/r/68713/#comment292787> key.substring ==> value.substring common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 123 (patched) <https://reviews.apache.org/r/68713/#comment292788> fromPrefix = actionValue.substring(idxPrefixSep + 1, idxSepDelimiter + 1) ==> actionValue.substring(idxSepDelimiter + 1, idxPrefixSep) common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 145 (patched) <https://reviews.apache.org/r/68713/#comment292790> String.replaceFirst() expects the first parameter to be regex - which may not be desirable here. Consider using StringUtils.replace() - Madhan Neethiraj On Sept. 15, 2018, 10:33 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68713/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2018, 10:33 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2873 > https://issues.apache.org/jira/browse/ATLAS-2873 > > > Repository: atlas > > > Description > ------- > > Atlas Import Transform Handler Implementation > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/entitytransform/Action.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java > PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/Condition.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/HdfsPathEntityHandler.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/HiveColumnEntityHandler.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/HiveDatabaseEntityHandler.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/HiveStorageDescriptorEntityHandler.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/entitytransform/TransformationConstants.java > PRE-CREATION > > common/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/impexp/AttributeTransform.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68713/diff/8/ > > > Testing > ------- > > > Thanks, > > Sarath Subramanian > >
