----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68735/#review208682 -----------------------------------------------------------
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java Line 430 (original), 430 (patched) <https://reviews.apache.org/r/68735/#comment292810> Why make initializeState() methods public? These methods don't seem to be called from outside this class. - Madhan Neethiraj On Sept. 17, 2018, 1:29 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68735/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2018, 1:29 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2860 > https://issues.apache.org/jira/browse/ATLAS-2860 > > > Repository: atlas > > > Description > ------- > > This patch includes changes in Atlas client to remove the dependency with > atlas application properties, so that it can be reused from non Atlas > application env. > > > Diffs > ----- > > > addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java > c0d0318d8 > client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java > ce4e014f7 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 > > client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java > d5392b2e4 > intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 > > > Diff: https://reviews.apache.org/r/68735/diff/1/ > > > Testing > ------- > > Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas > client. > > > Thanks, > > Nixon Rodrigues > >
