-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68771/#review208804
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Sept. 19, 2018, 10:26 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68771/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 10:26 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2882
>     https://issues.apache.org/jira/browse/ATLAS-2882
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> Described in JIRA.
> 
> **CURL**
> 
> _transform_
> [{\"conditions\":{\"__entity\":\"topLevel\"}, 
> \"action\":{\"__entity\":\"addClassification: replicated\"}}]
> 
> _import-options.json_ update top-level entities:
> {
>     "options": {
>         "transformers": ""[{\"conditions\":{\"__entity\":\"topLevel:\"}, 
> \"action\":{\"__entity\":\"addClassification: replicated\"}}]"",
>         "replicateFrom": "cl1"
>     }
> }
> 
> _import-options.json_ update all entities:
> {
>     "options": {
>         "transformers": ""[{\"conditions\":{\"__entity\":\"all:\"}, 
> \"action\":{\"__entity\":\"addClassification: replicated\"}}]"",
>         "replicateFrom": "cl1"
>     }
> }
> 
> _import-options.json_ with multiple conditions:
> {
>     "options": {
>         "transformers": "[{\"conditions\":{\"__entity\":\"all: \"}, 
> \"action\":{\"__entity\":\"addClassification: replicated\"}}, 
> {\"conditions\":{\"hive_db.clusterName\":\"EQUALS: 
> cl1\"},\"action\":{\"hive_db.clusterName\":\"SET: clx\"}}]",
>         "replicateFrom": "cl1"
>     }
> }
> 
> curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H 
> "Cache-Control: no-cache" -F request=@../docs/import-options.json -F 
> data=@../docs/hr-detailed.zip "http://localhost:21000/api/atlas/admin/import";
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/entitytransform/Action.java ca5f3a8c8 
>   
> intg/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java
>  c14f2fdde 
>   intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java 
> c1f286933 
>   intg/src/main/java/org/apache/atlas/entitytransform/Condition.java 
> d44f57509 
>   intg/src/main/java/org/apache/atlas/entitytransform/NeedsContext.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/entitytransform/TransformerContext.java 
> PRE-CREATION 
>   
> intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
>  69fba1eaf 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  a09385e08 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ZipSource.java 
> 9fcb1791b 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  b556fe9fd 
> 
> 
> Diff: https://reviews.apache.org/r/68771/diff/4/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> 
> Additional tests.
> 
> **Functional tests**
> Via CURL calls.
> 
> 
> File Attachments
> ----------------
> 
> stocks_dw-1.zip
>   
> https://reviews.apache.org/media/uploaded/files/2018/09/20/bcef1656-7e30-415b-a8ea-f284b9b3fd76__stocks_dw-1.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Reply via email to