----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68854/#review209045 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java Lines 542 (patched) <https://reviews.apache.org/r/68854/#comment293311> "@GraphTransaction" is not needed here, since a transaction will be created in the call from #562. Consider removing line #542. - Madhan Neethiraj On Sept. 26, 2018, 8:03 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68854/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 8:03 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Bugs: ATLAS-2892 > https://issues.apache.org/jira/browse/ATLAS-2892 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Created new method _AtlasTypeDefStore.deleteTypeByName_. > - Updated UI to use the new REST call. > > > Diffs > ----- > > dashboardv2/public/js/models/VTag.js fc5a97f516 > dashboardv2/public/js/views/tag/TagLayoutView.js ff2cb019d7 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 7f196c67f7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 4669286567 > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > a1fbf9737b > repository/src/test/resources/json/hiveDBv2.json PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 062d664c5f > > > Diff: https://reviews.apache.org/r/68854/diff/3/ > > > Testing > ------- > > **Unit tests** > - Added > > **Functional tests** > Via web ui. Using > [ATLAS-2894](https://issues.apache.org/jira/browse/ATLAS-2894) > > **Pre-commit build** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/723/ > > > Thanks, > > Ashutosh Mestry > >
