----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69015/#review209527 -----------------------------------------------------------
Fix it, then Ship it! graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java Lines 147 (patched) <https://reviews.apache.org/r/69015/#comment294019> 1. It will help to add following notes: - that Solr6Index.java is a copy of SolrIndex.java from JanusGraph (provide path within JanusGraph project) - highlight the reason for this copy/update 2. In the code, add comments around modified sections (from SolrIndex.java) /* ATLAS-2920 updates – start */ /* ATLAS-2920 updates – end */ - Madhan Neethiraj On Oct. 14, 2018, 1:50 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69015/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2018, 1:50 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2920 > https://issues.apache.org/jira/browse/ATLAS-2920 > > > Repository: atlas > > > Description > ------- > > Update JanusGraph Solr clients to use all zookeeper entries > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > 47e561bbe > graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69015/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/759/console > > > Thanks, > > Sarath Subramanian > >
