-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/#review209590
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java
Lines 498 (patched)
<https://reviews.apache.org/r/69038/#comment294117>

    It seems 'lower' will be set '1' for LIST & SET - even if this is an 
optional attribute. How is entity validation impacted by this change? i.e 
create/update of an entity with an empty value for LIST/SET type attribute.


- Madhan Neethiraj


On Oct. 16, 2018, 4:52 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69038/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2018, 4:52 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2922
>     https://issues.apache.org/jira/browse/ATLAS-2922
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> 
> - New condition added.
> - Refactoring, removal of duplicate code.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 
> 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e 
>   intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java
>  3c21465a34007173ef1ef0239c03133775722676 
> 
> 
> Diff: https://reviews.apache.org/r/69038/diff/1/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> New test added.
> 
> **Additional tests**
> Using CURL calls. Please see JIRA.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Reply via email to