> On Oct. 22, 2018, 4:42 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java
> > Lines 61 (patched)
> > <https://reviews.apache.org/r/69120/diff/1/?file=2101822#file2101822line61>
> >
> >     I guess this will endup adding "@Consumes(json)" to all APIs - even the 
> > ones that don't need any body. 
> >     
> >     Would this cause failure if REST client doesn't specify "Content-Type: 
> > application/json"? Please verify.
> 
> Apoorv Naik wrote:
>     This worked with POSTMAN and the UI didn't have any issues. Will check 
> with the Java REST Client as well.

This works with the AtlasClientV2 as well. Should be good to commit.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69120/#review209875
-----------------------------------------------------------


On Oct. 22, 2018, 4:31 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69120/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2018, 4:31 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Code changes include standardizing the addition of Consumes, Produces 
> annotation to the REST class instead of each method.
> Plugin changes include upgrade and config changes to enununciate.
> 
> 
> Diffs
> -----
> 
>   build-tools/src/main/resources/enunciate.xml dafd66f99 
>   pom.xml 91ec2c806 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 82d6f3594 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 5747f9240 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 8ae8f9993 
>   webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java 8b0316b4d 
>   webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java 
> 1014184fe 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 2091fdf0c 
> 
> 
> Diff: https://reviews.apache.org/r/69120/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and uploaded the latest website to apache.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to