-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69152/
-----------------------------------------------------------
Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval
bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2934
https://issues.apache.org/jira/browse/ATLAS-2934
Repository: atlas
Description
-------
This patch adds a REST API to scan specified entities for inconsistency of
__traitNames property value and fix it. If the property value does not match
the classification vertices associated with the entity, the value will be
updated to reflect the associated vertices.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateRequest.java
PRE-CREATION
intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateResult.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
e6f35fa1d
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
bddbf71e6
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
f03262faa
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java
PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
d9b1a412e
webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java
2dbc702e9
Diff: https://reviews.apache.org/r/69152/diff/1/
Testing
-------
Verified that the new API detects and fixes __traitNames property, for the
inconsistencies introduced. Here is a sample response from the call:
{
"state": "FIXED",
"entitiesScanned": 19021,
"entitiesFixed": 1,
"entitiesNotFixed": 0,
"entitiesOk": 19020,
"entitiesPartiallyFixed": 0,
"entities": {
"e87a1236-eeb4-4474-8cfd-a82117b8d1cd": {
"guid": "e87a1236-eeb4-4474-8cfd-a82117b8d1cd",
"name": "testDb.testTable@myCluster",
"state": "FIXED",
"status": "ACTIVE",
"typeName": "hive_table",
"issues": [
"incorrect property: traitNames has missing classifications:
[DATA_QUALITY]", "incorrect property: traitNames has unassigned
classifications: [UNKNOWN_TAG2, UNKNOWN_TAG]"
]
}
}
}
Thanks,
Madhan Neethiraj
