----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69179/#review210087 -----------------------------------------------------------
Ship it! Ship It! - Nikhil Bonte On Oct. 26, 2018, 5:26 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69179/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2018, 5:26 a.m.) > > > Review request for atlas, Kapildeo Nayak, Madhan Neethiraj, and Nixon > Rodrigues. > > > Bugs: ATLAS-2900 > https://issues.apache.org/jira/browse/ATLAS-2900 > > > Repository: atlas > > > Description > ------- > > **Root Cause** > The starting entity is a table. During navigation to discover more entities, > the entities that are discovered also discover table using column connection. > This causes table to be re-added to the creation order list. > > **Approach** > > Convert entity creation order to unique list. > > **CURL** > > ``` > curl -X POST -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" -d @../docs/export-options.json > http://localhost:21000/api/atlas/admin/export > ../docs/hr-1.zip > ``` > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 5e972a2cd > repository/src/main/java/org/apache/atlas/repository/util/UniqueList.java > eebbc4eff > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java > 86afd7f43 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > 18e7c419f > repository/src/test/resources/json/stocksDB-Entities/export-connected.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69179/diff/1/ > > > Testing > ------- > > **Unit tests** > - Additional tests. > - Minor modification to existing test. > > **Functional tests** > Using CURL calls. > > > Thanks, > > Ashutosh Mestry > >
