----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68363/#review210524 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 465 (patched) <https://reviews.apache.org/r/68363/#comment295231> Will this not fall through to other filters on failure? Is that what we really want here? webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 471 (patched) <https://reviews.apache.org/r/68363/#comment295234> It is probably due to the hiding of some of the logic in the previous block by leveraging ProxyUsers.authorize but the logic here is hard to follow on the surface. You may want to just add comment/s to make sure that it is understood that the atlasProxyUsers is being checked in both cases. The &&'d if and else-if checks makes for some mental gymnastics here as well. - Larry McCay On Nov. 13, 2018, 7:51 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68363/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2018, 7:51 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2824 > https://issues.apache.org/jira/browse/ATLAS-2824 > > > Repository: atlas > > > Description > ------- > > This patch includes code to support request from knox proxy, where the proxy > is already known and trusted to Atlas via configuration. Atlas intercepts the > incoming requests and if it from knox proxy. Atlas allow the knox's doAs user > to create session in Atlas. > > Configs required:- > > atlas.authentication.allow.trustedproxy :- property allow trusted proxy > support > atlas.proxyuser.knox.hosts :- property to add trusted hosts > atlas.proxyuser.knox.users :- property to add trusted users > atlas.proxyuser.knox.groups :- property to add trusted groups > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > e5c40d061 > > webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java > 21d4f8526 > webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java > 49d56b20c > > > Diff: https://reviews.apache.org/r/68363/diff/7/ > > > Testing > ------- > > Tested > > * Atlas UI from Trusted Knox Proxy with Knox SSO loginpage. > * Atlas UI from Knox Proxy with Atlas Login. > * Atlas UI from Knox Proxy with SSO Filter enabled at Atlas. > * Atlas UI with Atlas Login. > * Atlas api from curl with BASIS & Kerberos headers > > > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console > > Topology Used:- > > > <topology> > <gateway> > ????????<provider> > ????????????<role>federation</role> > ????????????<name>SSOCookieProvider</name> > ????????????<enabled>true</enabled> > ????????????<param> > ????????????????<name>sso.authentication.provider.url</name> > ????????????????<value>{KNOXHOST}/gateway/knoxsso/knoxauth/login.html</value> > ????????????</param> > ????????</provider> > ????????<provider> > ????????????<role>identity-assertion</role> > ????????????<name>Default</name> > ????????????<enabled>true</enabled> > ????????</provider> > </gateway> > <service> > <role>ATLAS</role> > <url>{ATLAS_HOST}:21000/</url> > </service> > <service> > <role>ATLAS-API</role> > <url>{ATLAS_HOST}:21000</url> > </service> > </topology> > > > Thanks, > > Nixon Rodrigues > >
