-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69503/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
Bugs: ATLAS-2976
https://issues.apache.org/jira/browse/ATLAS-2976
Repository: atlas
Description
-------
Old implementation requires service_type in order to render the icon.
New implementation removes that dependency.
it will check if <type_name>.png is present in the entity-icon folder, if not
then check for the <service_type>.png and if both names are not present then
default icon will take place
Diffs
-----
dashboardv2/public/img/entity-icon/avro/avro.png
dashboardv2/public/img/entity-icon/avro/disabled/avro.png
dashboardv2/public/img/entity-icon/default/db.png
dashboardv2/public/img/entity-icon/default/disabled/db.png
dashboardv2/public/img/entity-icon/default/disabled/process.png
dashboardv2/public/img/entity-icon/default/disabled/table.png
dashboardv2/public/img/entity-icon/default/process.png
dashboardv2/public/img/entity-icon/default/table.png
dashboardv2/public/img/entity-icon/falcon/disabled/falcon.png
dashboardv2/public/img/entity-icon/falcon/falcon.png
dashboardv2/public/img/entity-icon/file_system/disabled/file_system.png
dashboardv2/public/img/entity-icon/file_system/file_system.png
dashboardv2/public/img/entity-icon/hadoop/disabled/hadoop.png
dashboardv2/public/img/entity-icon/hadoop/hadoop.png
dashboardv2/public/img/entity-icon/hbase/disabled/hbase.png
dashboardv2/public/img/entity-icon/hbase/disabled/hbase_column.png
dashboardv2/public/img/entity-icon/hbase/disabled/hbase_column_family.png
dashboardv2/public/img/entity-icon/hbase/disabled/hbase_table.png
dashboardv2/public/img/entity-icon/hbase/hbase.png
dashboardv2/public/img/entity-icon/hbase/hbase_column.png
dashboardv2/public/img/entity-icon/hbase/hbase_column_family.png
dashboardv2/public/img/entity-icon/hbase/hbase_table.png
dashboardv2/public/img/entity-icon/hive/disabled/hive.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_column.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_column_lineage.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_db.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_process.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_storagedesc.png
dashboardv2/public/img/entity-icon/hive/disabled/hive_table.png
dashboardv2/public/img/entity-icon/hive/hive.png
dashboardv2/public/img/entity-icon/hive/hive_column.png
dashboardv2/public/img/entity-icon/hive/hive_column_lineage.png
dashboardv2/public/img/entity-icon/hive/hive_db.png
dashboardv2/public/img/entity-icon/hive/hive_process.png
dashboardv2/public/img/entity-icon/hive/hive_storagedesc.png
dashboardv2/public/img/entity-icon/hive/hive_table.png
dashboardv2/public/img/entity-icon/kafka/disabled/jms_topic.png
dashboardv2/public/img/entity-icon/kafka/disabled/kafka.png
dashboardv2/public/img/entity-icon/kafka/jms_topic.png
dashboardv2/public/img/entity-icon/kafka/kafka.png
dashboardv2/public/img/entity-icon/rdbms/disabled/rdbms.png
dashboardv2/public/img/entity-icon/rdbms/disabled/rdbms_column.png
dashboardv2/public/img/entity-icon/rdbms/disabled/rdbms_db.png
dashboardv2/public/img/entity-icon/rdbms/disabled/rdbms_table.png
dashboardv2/public/img/entity-icon/rdbms/rdbms.png
dashboardv2/public/img/entity-icon/rdbms/rdbms_column.png
dashboardv2/public/img/entity-icon/rdbms/rdbms_db.png
dashboardv2/public/img/entity-icon/rdbms/rdbms_table.png
dashboardv2/public/img/entity-icon/spark/spark.png
daaa56c6143df5f40eb9b28fde139083516e2f82
dashboardv2/public/img/entity-icon/sqoop/disabled/sqoop.png
dashboardv2/public/img/entity-icon/sqoop/disabled/sqoop_db.png
dashboardv2/public/img/entity-icon/sqoop/disabled/sqoop_process.png
dashboardv2/public/img/entity-icon/sqoop/sqoop.png
dashboardv2/public/img/entity-icon/sqoop/sqoop_db.png
dashboardv2/public/img/entity-icon/sqoop/sqoop_process.png
dashboardv2/public/img/entity-icon/storm/disabled/storm.png
dashboardv2/public/img/entity-icon/storm/disabled/storm_bolt.png
dashboardv2/public/img/entity-icon/storm/disabled/storm_spout.png
dashboardv2/public/img/entity-icon/storm/disabled/storm_topology.png
dashboardv2/public/img/entity-icon/storm/storm.png
dashboardv2/public/img/entity-icon/storm/storm_bolt.png
dashboardv2/public/img/entity-icon/storm/storm_spout.png
dashboardv2/public/img/entity-icon/storm/storm_topology.png
dashboardv2/public/js/utils/Utils.js 6ebfe94cf
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 46d427b55
Diff: https://reviews.apache.org/r/69503/diff/1/
Testing
-------
Done one round of testing
Thanks,
keval bhatt
