----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69566/#review211438 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java Lines 888-889 (patched) <https://reviews.apache.org/r/69566/#comment296549> the body of both removeTermAssignmentFromEntities() line# 861 and disassociateTermAssignmentFromEntities() line# 887 is same. Consider moving the common code block to a separate method and invoke it from @DELETE and @PUT methods. - Sarath Subramanian On Dec. 13, 2018, 4:56 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69566/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2018, 4:56 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2995 > https://issues.apache.org/jira/browse/ATLAS-2995 > > > Repository: atlas > > > Description > ------- > > ISSUE: > > Request to disassociate a term from an entity via knox proxy succeeds , but > the disassociation doesn't happen. > > Cause: > > Knox Proxy Gateway does not support DELETE method api with body. > > Solution :- > > Come up with another API with PUT method with body. > > > Diffs > ----- > > dashboardv2/public/js/models/VGlossary.js f33ef0fe1 > webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 8ae8f9993 > > > Diff: https://reviews.apache.org/r/69566/diff/1/ > > > Testing > ------- > > Tested with new api method from UI with put method. > > > Thanks, > > Nixon Rodrigues > >
