----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69707/#review212181 -----------------------------------------------------------
Fix it, then Ship it! 0001-ATLAS-3020-Audit-APIs-for-classification-updates.patch Lines 1 (patched) <https://reviews.apache.org/r/69707/#comment297846> Patch file included by mistake? Please remove before committing the patch. - Madhan Neethiraj On Jan. 21, 2019, 7:59 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69707/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2019, 7:59 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3029 > https://issues.apache.org/jira/browse/ATLAS-3029 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Scan HBase 'ATLAS_ENTITY_AUDIT_EVENTS' table with approprite paramters. > - New: Package the output into _AtlasEntityHeaders_. > - Provide _REST APIs_ to _EntityREST_. > - _AtlasClientV2_ updated to support the new endpoints. > > **Rules for _setClassifications_** > - If incoming _AtlasEntityHeader_: > - Has no classifications: Delete entity's classification. > - Has classifications & entity does not have the classification: Add to > entity's classifications. > - Has classifications & entity has the classification: Update entity's > classification. > > > **CURL** > > _Fetch_ > curl -X GET -u admin:passWord -H 'Content-Type: application/json' > > 'http://localhost:21000/api/atlas/v2/entity/bulk/headers?tagUpdateStartTime=1546992000000' > \ > > _Udpate_ > curl -X POST -u admin:passWord -H 'Content-Type: application/json' > 'http://localhost:21000/api/atlas/v2/entity/bulk/setClassifications' > -d @fetched-classifications.json > > > **Not supported** > - Cassandra based Audits. > - For testing: In-memory audits. > > > Diffs > ----- > > 0001-ATLAS-3020-Audit-APIs-for-classification-updates.patch PRE-CREATION > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7c8caee89 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaders.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java > eb78f8f70 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java > aab2d5b6c > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 6f4415fa8 > > repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java > dca3b853e > > repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java > e3a607809 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 750fa1775 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 35aa3afed > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 066abc109 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java > PRE-CREATION > > repository/src/test/resources/json/classification-association/col-entity-None.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/col-entity-PII-FIN_PII.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/col-entity-PII.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/col-entity-T1-prop-Tn.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-FIN_PII.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-None.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-PII-VENDOR_PII.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-PII.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-Tx-prop-T1.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-Tx.json > PRE-CREATION > > repository/src/test/resources/json/classification-association/header-empty.json > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 68c132c37 > > > Diff: https://reviews.apache.org/r/69707/diff/9/ > > > Testing > ------- > > **Unit tests** > New tests added. > > **Functional tests** > Via CURL calls. > > **Volume tests** > Loads of over 2000 entities. > Classification types: 50 > Entities: 8102 > File size: 3.3 MB. > Duration: 11 mins > > > File Attachments > ---------------- > > entity-headers.json > > https://reviews.apache.org/media/uploaded/files/2019/01/14/a23bead7-6990-4d5b-b3b8-f46f990f5d99__entity-headers.json > > > Thanks, > > Ashutosh Mestry > >
