----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69816/#review212248 -----------------------------------------------------------
Fix it, then Ship it! Ship It! repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 759 (patched) <https://reviews.apache.org/r/69816/#comment297978> consider reusing existing method -> AtlasGraphUtilsV2.findByGuid(guid) to retrieve vertex using guid. - Sarath Subramanian On Jan. 23, 2019, 1 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69816/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2019, 1 a.m.) > > > Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, > Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3035 > https://issues.apache.org/jira/browse/ATLAS-3035 > > > Repository: atlas > > > Description > ------- > > Updated entity-get/delete to retrieve/delete soft-ref entities for owne-ref > attributes > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 27409c742 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 45bf8dca4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > c57e30ab5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 98734cc1d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 912bc3ecd > > > Diff: https://reviews.apache.org/r/69816/diff/1/ > > > Testing > ------- > > - verified that entity-get populates extInfo with details of owned-ref > soft-ref entities > - verified that entity-delete marks owned-ref soft-ref entities as deleted > > > Thanks, > > Madhan Neethiraj > >
