----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69682/#review212287 -----------------------------------------------------------
Please add unit tests. - Ashutosh Mestry On Jan. 18, 2019, 7:35 a.m., Kapildeo Nayak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69682/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2019, 7:35 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3024 > https://issues.apache.org/jira/browse/ATLAS-3024 > > > Repository: atlas > > > Description > ------- > > 1) Created a database db9 with a table and external table and exported it. > 2) On Importing , renamed it to db11 using : > {\"conditions\": {\"hive_db.name\":\"EQUALS: > db9\"},\"action\":{\"hive_db.name\":\"SET: db11\"}}]" > > 3. Attributes related to hive_db location, hive_storagedesc location and > attributes of hive_process and hdfs_path are not renamed and still have db9 > reference. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java > 975e4ddd6 > > intg/src/main/java/org/apache/atlas/entitytransform/HiveDatabaseEntityHandler.java > b8032aa09 > > intg/src/main/java/org/apache/atlas/entitytransform/HiveProcessEntityHandler.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/entitytransform/HiveStorageDescriptorEntityHandler.java > 38de206d1 > > intg/src/main/java/org/apache/atlas/entitytransform/TransformationConstants.java > 247de7320 > > > Diff: https://reviews.apache.org/r/69682/diff/4/ > > > Testing > ------- > > Tested in import-export with transformers options. > > > Thanks, > > Kapildeo Nayak > >
