-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69844/
-----------------------------------------------------------

Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, 
Kapildeo Nayak, Mehul Parikh, Nikhil Bonte, Nixon Rodrigues, and Sarath 
Subramanian.


Bugs: ATLAS-3037
    https://issues.apache.org/jira/browse/ATLAS-3037


Repository: atlas


Description
-------

- for attributes of type object-id, incoming requests are likely to have 
unassigned-id. Current implementation to check for attribute value change 
incorrectly flags these attributes as changed, as it compares unassigned-id 
with assigned-id (from the store). Fixed this issue, by passing down 
guidAssignments to compare methods
- added instrumentation to measure time taken by various blocks, to aid in 
performance improvement


Diffs
-----

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 c59b186eb 
  intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java ee6eb8ecf 
  intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java aa9f72220 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
ee0ac230f 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0bfe6fdb3 
  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 1ea921a4f 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java cfee6e88f 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0c5c91b33 
  intg/src/main/java/org/apache/atlas/type/AtlasType.java 228198a7f 
  intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 316496da9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 e8e5400b7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 8f8ddb8c9 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 d49f4a555 
  repository/src/test/resources/tag-prop-2.zip 
345a88c23c93a526fd9313e5866d8dcd3cb8e56f 
  
webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java
 d5ff4235a 


Diff: https://reviews.apache.org/r/69844/diff/1/


Testing
-------

- verified that entities with no change in attribute values are not updated
- verified that all unit and integration tests pass successfully


Thanks,

Madhan Neethiraj

Reply via email to