-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69822/#review212361
-----------------------------------------------------------




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 231 (patched)
<https://reviews.apache.org/r/69822/#comment298142>

    This will ignore ValueTmpTable only if its in one of the dummy-database. I 
think such tables should be ignored irrespective of the database. Please review.
    
    case TABLE:
    case PARTITION: {
      String  dbName    = entity.getTable().getDbName();
      String  tableName = entity.getTable().getTableName();
      boolean skipTable = 
StringUtils.isNotEmpty(context.getIgnoreValuesTmpTableNamePrefix()) && 
tableName.toLowerCase().startsWith(context.getIgnoreValuesTmpTableNamePrefix());
    
      if (!skipTable) {
        skipTable = context.getIgnoreDummyTableName().contains(tableName) && 
context.getIgnoreDummyDatabaseName().contains(dbName);
      }
    
      if (!skipTable) {
        Table table = getHive().getTable(dbName, tableName);
    
        ret = toTableEntity(table, entityExtInfo);
      }
    }
    break;


- Madhan Neethiraj


On Jan. 23, 2019, 3:07 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69822/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2019, 3:07 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3033
>     https://issues.apache.org/jira/browse/ATLAS-3033
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS Hive Hook fails to notify for CTAS queries involving UDFs, Hook fails 
> with the exception as below
> 
> org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table not found 
> _dummy_table.
> 
> 
> FIX :-  Added fix to skip hive _dummy_table temp table while getting Table 
> object details from hiveContext during lineage input creation.
> 
> 
> Diffs
> -----
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  249f48b5f 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 4a6b41786 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  5c52cf442 
> 
> 
> Diff: https://reviews.apache.org/r/69822/diff/1/
> 
> 
> Testing
> -------
> 
> Tested by creating hive table with CTAS which creates temp table.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Reply via email to