----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69847/#review212393 -----------------------------------------------------------
Fix it, then Ship it! Ship It! repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 235 (patched) <https://reviews.apache.org/r/69847/#comment298158> the entity vertex can already be in deleted state, consider checking: hasUpdates = GraphHelper.getStatus(entityVertex) != entity.getStatus() - Sarath Subramanian On Jan. 27, 2019, 11:57 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69847/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2019, 11:57 p.m.) > > > Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, > Kapildeo Nayak, Mehul Parikh, Nikhil Bonte, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3037 > https://issues.apache.org/jira/browse/ATLAS-3037 > > > Repository: atlas > > > Description > ------- > > - updated createOrUpdate() API to skip entities that don't have any change in > attribute value; this will help avoid unnecessary entity-update notificaiton > and audit log generation > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java > 737e1cc52 > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 89ba22075 > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 1039de661 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 707d7b27e > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java e29f3a488 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 8b702a712 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 45c58bdcd > intg/src/main/java/org/apache/atlas/type/AtlasType.java ae7044d39 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 18f8b25d5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 1d89c8344 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 5093714c8 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportSkipLineageTest.java > 524aa1e86 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java > c4480ad9f > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > 8664fa1e6 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 89b0ceaf7 > repository/src/test/resources/reporting-v1-full.zip > c2fc9c2f5a05d693e7fc236f418fc28ad2002f74 > > webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java > d5ff4235a > > > Diff: https://reviews.apache.org/r/69847/diff/1/ > > > Testing > ------- > > - verified that entities with no change in attribute values are not updated > - verified that all unit and integration tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
