----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69882/#review212511 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Line 477 (original), 482 (patched) <https://reviews.apache.org/r/69882/#comment298314> should we cache - guid, vertex and entityType inside method AtlasGraphUtilsV2.findByGuid(guid) ? - Sarath Subramanian On Feb. 3, 2019, 12:31 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69882/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2019, 12:31 p.m.) > > > Review request for atlas, Ashutosh Mestry and Sarath Subramanian. > > > Bugs: ATLAS-3044 > https://issues.apache.org/jira/browse/ATLAS-3044 > > > Repository: atlas > > > Description > ------- > > Updated import process to perform entity-delete operation, instead of simply > updating entity status > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 18018d7b3 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 6ad830a5d > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 45892629d > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 45bf8dca4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 0ae57c120 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java > a6a18dc1a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > e0668cb3b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 82b563e84 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > e288cdf2c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityMutationContext.java > 453dbe6ac > server-api/src/main/java/org/apache/atlas/RequestContext.java 29f297467 > > webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java > 9cc5498e5 > > > Diff: https://reviews.apache.org/r/69882/diff/2/ > > > Testing > ------- > > - verified that notifications were generated for entities deleted through > import > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/916/ > > > Thanks, > > Madhan Neethiraj > >
