----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69899/#review212606 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Feb. 5, 2019, 4:16 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69899/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2019, 4:16 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-3045 > https://issues.apache.org/jira/browse/ATLAS-3045 > > > Repository: atlas > > > Description > ------- > > * The atlas-server-package.xml incorrectly tries to include the jar, and the > shell script from atlas-migration-exporter > * classification-updater is not added to that atlas-server-package.xml > * There is no separate classification-updater assembly created > * the tools are not built with the rest of the Atlas server > > > Diffs > ----- > > distro/pom.xml 12a709c19 > distro/src/main/assemblies/atlas-server-package.xml 248645a60 > distro/src/main/assemblies/classification-updater.xml PRE-CREATION > pom.xml d9b2c9dc8 > > > Diff: https://reviews.apache.org/r/69899/diff/1/ > > > Testing > ------- > > Tested with executing: "mvn -B -nsu -Dfindbugs.skip=true -Pgpg > -DskipDocs=true -Pdist -DskipTests -DskipITs install" > and investigating the generated zips under distro/target/... > > > Thanks, > > Zsombor Gegesy > >
