----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70019/ -----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3051 https://issues.apache.org/jira/browse/ATLAS-3051 Repository: atlas Description ------- - when a container attribute in COMPOSITION relationship is added to AtlasEntityType, ownedRef constrinat is added, so that existing behaviour of ownedRef attribute will be extended to these relationship attributes as well - added validation for contained entities in COMPOSITION relationship, to require container is set i.e. mandatory attribute Diffs ----- intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java a4d6bedfb intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0d63325da intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 264c4fc30 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java b2bd896b8 Diff: https://reviews.apache.org/r/70019/diff/1/ Testing ------- - verified that container entity delete causes its contained entities to be deleted - verified that entity-create requires container value be set for contined entities - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/927/ Thanks, madhan