----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70039/#review213068 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On Feb. 21, 2019, 9:01 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70039/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2019, 9:01 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3055 > https://issues.apache.org/jira/browse/ATLAS-3055 > > > Repository: atlas > > > Description > ------- > > - updated graph-mapper to move relationship attributes present in > 'attributes' to 'relationshipAttributes' > - updated entity-walk through look for relationship attribute in 'attributes' > when its not present in 'relationshipAttributes', since this run before > graph-mapper gets to moving attributes around > - fixed GlossaryUtils.createRelationship() to call getOrCreateRelationship(), > instead of ignoring RELATIONSHIP_ALREADY_EXISTS exception > - added gui->vertex mapping at the graph-transaction level to optmize (by > avoiding graph query) > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7166caa8d > repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java > cbd2226b2 > repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java > cec4c2303 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > ddab2bf0e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > f610f6f06 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > 254853726 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 173fe02ff > > > Diff: https://reviews.apache.org/r/70039/diff/1/ > > > Testing > ------- > > Pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/931/ > > > Thanks, > > madhan > >
