----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70041/#review213087 -----------------------------------------------------------
Fix it, then Ship it! Ship It! webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java Lines 71 (patched) <https://reviews.apache.org/r/70041/#comment298957> duplicate registration of preprocessor - HivePreprocessor.HiveStorageDescPreprocessor() line 71 and 72 webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java Lines 121 (patched) <https://reviews.apache.org/r/70041/#comment298956> clearRefAtrributes => clearRefAttributes - Sarath Subramanian On Feb. 21, 2019, 7:28 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70041/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2019, 7:28 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3056 > https://issues.apache.org/jira/browse/ATLAS-3056 > > > Repository: atlas > > > Description > ------- > > - updated RDBMS model to remove attributes that use ownedRef/inverseRef > constraints > - updated corresponding relationship-types as COMPOSITION > - updated notification processing to fix notifications of earlier model for > the model changes > > > Diffs > ----- > > addons/models/2000-RDBMS/2010-rdbms_model.json 386446c8c > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 6d03ba492 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java > bdea14adf > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70041/diff/2/ > > > Testing > ------- > > Pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/932/ > > > Thanks, > > madhan > >
