----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70124/#review213422 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java Lines 454 (patched) <https://reviews.apache.org/r/70124/#comment299360> should we set the value in RequestContext before for-loop #427, instead of setting and unsetting before each patch operation? - Sarath Subramanian On March 4, 2019, 8:14 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70124/ > ----------------------------------------------------------- > > (Updated March 4, 2019, 8:14 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, > Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3065 > https://issues.apache.org/jira/browse/ATLAS-3065 > > > Repository: atlas > > > Description > ------- > > - added typedef patch REMOVE_LEGACY_ATTRIBUTES, to remove legacy attributes > for a given relationship-type > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e84701433 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > d76f7fad1 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > 25dd81db1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java > 3602c80bd > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java > 1b67f119d > server-api/src/main/java/org/apache/atlas/RequestContext.java 18a1b7b52 > > > Diff: https://reviews.apache.org/r/70124/diff/2/ > > > Testing > ------- > > - verified with the attached type-patch file that legacy attributes for hive > types were removed correctly > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/942/ > > > File Attachments > ---------------- > > typedef patch to remove legacy attributes from hive entity-types > > https://reviews.apache.org/media/uploaded/files/2019/03/05/d6083055-0864-4fe9-ba27-0621ead6b054__008-remove-hive-legacy-attributes.json > > > Thanks, > > madhan > >
