----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70106/#review213424 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On March 3, 2019, 11:04 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70106/ > ----------------------------------------------------------- > > (Updated March 3, 2019, 11:04 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Mehul > Parikh, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3063 > https://issues.apache.org/jira/browse/ATLAS-3063 > > > Repository: atlas > > > Description > ------- > > - added field AtlasRelatedObjectId.relationshipType, to enable > relationship-type to be provided during entity create/update > - added field AtlasRelationshipDef.relationshipLabel to specify the label to > be used for graph-edge that represents a relationship > - updated AtlasEntityType to account for cases where an attribute can be part > of more than one relationship-type > - updated entity normalization/validation to use > AtlasRelatedObjectId.relationshipType, if specified > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java d677814d6 > > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java > fde2629b9 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > d76f7fad1 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8960703e0 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 36e459a44 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 644ed79d6 > intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 2e7453673 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 819dfe57f > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 2378d6bb3 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > b4542b711 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 97e3e2557 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 5632520f7 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java > f528b1715 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > 23dc83a88 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 18eb337ab > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > 798b3621e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java > 3602c80bd > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java > 47a7546e7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > baaca0b05 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > e2b74338e > > > Diff: https://reviews.apache.org/r/70106/diff/1/ > > > Testing > ------- > > - verified that 'relationshipType' specified for relationship attributes > results in expected entity association > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/938/ > > > Thanks, > > madhan > >
