----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70144/#review213527 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On March 6, 2019, 10:04 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70144/ > ----------------------------------------------------------- > > (Updated March 6, 2019, 10:04 p.m.) > > > Review request for atlas, Ayub Pathan, Ashutosh Mestry, keval bhatt, Nikhil > Bonte, Nixon Rodrigues, Sarath Subramanian, and Sharmadha Sainath. > > > Bugs: ATLAS-3056 > https://issues.apache.org/jira/browse/ATLAS-3056 > > > Repository: atlas > > > Description > ------- > > Earlier commit for ATLAS-3056 updated the RDBMS types by removing > ownedRef/inverseRef attributes. This approach works for new Atlas > environments, but wouldn't update the types in an existing Atlas deployment. > > Hence this subsequent patch to use recently added type-patch > REMOVE_LEGACY_ATTRIBUTES, to remove ownedRef/inverseRef attributes. This > apporach works well for existing Atlas deployments as well. Please note that > model changes in earlier commit were reverted in this patch, as the updates > are now handled by new type-patch 003-remove-rdbms-legacy-attributes.json. > > > Diffs > ----- > > addons/models/2000-RDBMS/2010-rdbms_model.json d4e18050c > addons/models/2000-RDBMS/patches/003-remove-rdbms-legacy-attributes.json > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java > 18e7407ff > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > a86282e93 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java > bfee34ef0 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > e9a01515c > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > 2d2c09ad9 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java > 3933cc68b > > > Diff: https://reviews.apache.org/r/70144/diff/1/ > > > Testing > ------- > > - verified that RDBMS entities created earlier (i.e. before applying > type-patch 003-remove-rdbms-legacy-attributes.json) can be > read/updated/deleted after the applying this patch > - verified create/update/delete of RDBMS entities succeed after applying this > patch > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/947/ > > > Thanks, > > madhan > >
