> On March 8, 2019, 8:59 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/patches/008-remove-hive-legacy-attributes.json > > Lines 46 (patched) > > <https://reviews.apache.org/r/70162/diff/1/?file=2129632#file2129632line46> > > > > why are we swapping endDefs here?
Once isLegacyAttribute flag was set to false for both ends, the edge created for the relationship is from end1->end2. This results in existing relationships to be ignored for hive_column_lineage->hive_process, as the order of ends don't match the edge direction. Hence this change is required. - madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70162/#review213569 ----------------------------------------------------------- On March 9, 2019, 1:29 a.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70162/ > ----------------------------------------------------------- > > (Updated March 9, 2019, 1:29 a.m.) > > > Review request for atlas, Ayub Pathan, Ashutosh Mestry, keval bhatt, Mehul > Parikh, Nikhil Bonte, Nixon Rodrigues, Sarath Subramanian, and Sharmadha > Sainath. > > > Bugs: ATLAS-3067 > https://issues.apache.org/jira/browse/ATLAS-3067 > > > Repository: atlas > > > Description > ------- > > Using recently added type-patch REMOVE_LEGACY_ATTRIBUTES, removed > ownedRef/inverseRef attributes from hive entity-defs. > > > Diffs > ----- > > addons/models/1000-Hadoop/patches/008-remove-hive-legacy-attributes.json > PRE-CREATION > addons/models/2000-RDBMS/patches/003-remove-rdbms-legacy-attributes.json > d087c660f > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > d12284ef1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java > 35d0577d0 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 50559dda9 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java > 7eba27a49 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java > d54c88def > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > 0f95fbabc > > > Diff: https://reviews.apache.org/r/70162/diff/2/ > > > Testing > ------- > > - verified that Hive entities created earlier (i.e. before applying > type-patch 008-remove-hive-legacy-attributes.json) can be > read/updated/deleted after the applying this patch > - verified create/update/delete of Hive entities succeed after applying this > patch > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/948/ > > > Thanks, > > madhan > >
