----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70236/#review213900 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java Lines 90 (patched) <https://reviews.apache.org/r/70236/#comment300018> For entities with multiple uniq-attributes (i.e. attributes.size() > 1), this will increase the count more than once. I would suggest to move line #90 to #72, like: for (Iterator<AtlasVertex> iterator = findActiveEntityVerticesByType(typeName); iterator.hasNext(); entitiesProcessed++) { // ... } - madhan On March 22, 2019, 12:59 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70236/ > ----------------------------------------------------------- > > (Updated March 22, 2019, 12:59 a.m.) > > > Review request for atlas, Ashutosh Mestry, Kapildeo Nayak, madhan, Nikhil > Bonte, and Nixon Rodrigues. > > > Bugs: ATLAS-3077 > https://issues.apache.org/jira/browse/ATLAS-3077 > > > Repository: atlas > > > Description > ------- > > We have Atlas typedef patches available to update out of box type > definitions. This JIRA will introduce a new java patch framework to handle > changes to the graph database not specific to type changes. > > For e.g. In case of migration, to add/update property keys in vertices - java > patch framework can be used, which will be run at the atlas startup time > during bootstrap. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/patches/AtlasPatch.java cdf2441d2 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 4805435c7 > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasJavaPatchHandler.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/patches/PatchContext.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > 337a6db6c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > 2d5fd9706 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 01bdcf7e2 > > > Diff: https://reviews.apache.org/r/70236/diff/3/ > > > Testing > ------- > > Verified with migrated data that patch was applied cleanly > > > Thanks, > > Sarath Subramanian > >
