----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70292/#review213966 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Line 401 (original), 469 (patched) <https://reviews.apache.org/r/70292/#comment300094> Shouldn't this (sd.table) be a relationshipAttribute as well? Please review. webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Lines 484 (patched) <https://reviews.apache.org/r/70292/#comment300095> Shouldn't this (column.table) be a relationshipAttribute? Please review. webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Line 554 (original), 644 (patched) <https://reviews.apache.org/r/70292/#comment300091> - consider replacing "@cl1" with a constant - here and other references, like: private static final String CLUSTER_SUFFIX = "@cl1"'; - Consider using Collections.<String, Object>singletonMap(REFERENCEABLE_ATTRIBUTE_NAME, table + "@cl1"); - madhan On March 25, 2019, 6:31 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70292/ > ----------------------------------------------------------- > > (Updated March 25, 2019, 6:31 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon > Rodrigues. > > > Bugs: ATLAS-3095 > https://issues.apache.org/jira/browse/ATLAS-3095 > > > Repository: atlas > > > Description > ------- > > QuickstartV2 doesn't uses relationships to create entities. This Jira adds > new relationshipDefs and creates sample entities using relationship. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > e3de46035 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 3ba8a1294 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > dda324b7d > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 8bd2aadef > > > Diff: https://reviews.apache.org/r/70292/diff/1/ > > > Testing > ------- > > Validated by manually running quickstart.py and ensured entities created > successfully. > > > Thanks, > > Sarath Subramanian > >
