mneethiraj commented on a change in pull request #32: ATLAS-3092: Atlas Plugin 
ClassLoader Doesn't Restore Thread ClassLoader
URL: https://github.com/apache/atlas/pull/32#discussion_r268800769
 
 

 ##########
 File path: 
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
 ##########
 @@ -206,7 +209,7 @@ public void activate() {
         if (LOG.isDebugEnabled()) {
             LOG.debug("==> AtlasPluginClassLoader.activate()");
         }
-
+        previousLoader = Thread.currentThread().getContextClassLoader();
 
 Review comment:
   AtlasPluginClassLoader instance could be used in multiple threads 
simultaneously. So, saving 'previousLoader' in an instance member is not a safe 
option. @rmani (Ramesh Mani) is working on addressing the same issue in Ranger 
via RANGER-2376. I would suggest to wait for his Ranger fix and apply the same 
in Atlas as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to