[ 
https://issues.apache.org/jira/browse/ATLAS-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802838#comment-16802838
 ] 

Madhan Neethiraj commented on ATLAS-3102:
-----------------------------------------

[~Zep] - thanks for going through all typedef classes. You are right about 
ClassificationDef - serviceType doesn't apply to classifications. I will review 
and merge your patch shortly.

> Missing setServiceType in AtlasBaseTypeDef copy constructor
> -----------------------------------------------------------
>
>                 Key: ATLAS-3102
>                 URL: https://issues.apache.org/jira/browse/ATLAS-3102
>             Project: Atlas
>          Issue Type: Bug
>          Components: atlas-intg
>    Affects Versions: 2.0.0
>         Environment: All OS
>            Reporter: Diego Marino Monetti
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The AtlasBaseServiceType copy constructor misses of the setServiceType to set 
> the serviceType. The problem was corrected in the pull request.
> Also the AtlasRelationshipDef copy costructor throws an AtlasBaseException 
> that is unused because nothing can throw that exception in 
> AtlasRelationshipDef constructor and its superclasses. Removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to