----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70357/#review214336 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 1450 (patched) <https://reviews.apache.org/r/70357/#comment300535> Minor optimization: if (cardinality == LIST) { for (Object value : values) { addToListProperty(vertex, vertexPropertyName, value); } } else { for (Object value : values) { addToSetProperty(vertex, vertexPropertyName, value); } } - Madhan Neethiraj On April 2, 2019, 4:37 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70357/ > ----------------------------------------------------------- > > (Updated April 2, 2019, 4:37 a.m.) > > > Review request for atlas, Ashutosh Mestry, Kapildeo Nayak, Madhan Neethiraj, > Nikhil Bonte, and Nixon Rodrigues. > > > Bugs: ATLAS-3112 > https://issues.apache.org/jira/browse/ATLAS-3112 > > > Repository: atlas > > > Description > ------- > > Array attributes with cardinality LIST or SET is not indexed in the indexing > store. To allow index query to search on array attributes, array attributes > needs to be indexed. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java > b1e2c5dd8 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 4e18432e7 > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > f72b41214 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > c57f8e3c7 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 449f382bc > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > 2882f097a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 4f93c8f33 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java > eb594f2b1 > > > Diff: https://reviews.apache.org/r/70357/diff/2/ > > > Testing > ------- > > Verified in Solr that array attributes - superTypeNames, traitNames and > propagatedTraitNames are indexed. > > Precommit job: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1009/console > > > Thanks, > > Sarath Subramanian > >
