sarathkumarsubramanian commented on a change in pull request #39:
ATLAS-3071:Add Functionalities to Collect Notification Metrics
URL: https://github.com/apache/atlas/pull/39#discussion_r272443590
##########
File path:
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
##########
@@ -685,6 +686,12 @@ void handleMessage(AtlasKafkaMessage<HookNotification>
kafkaMsg) throws AtlasSer
}
}
+ if (isFailedMsg) {
Review comment:
689-693 should be moved to finally block below after kafka commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
