----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70304/#review214442 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On April 1, 2019, 3:15 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70304/ > ----------------------------------------------------------- > > (Updated April 1, 2019, 3:15 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3090 > https://issues.apache.org/jira/browse/ATLAS-3090 > > > Repository: atlas > > > Description > ------- > > **Approach** > > - Additional methods added to _WorkItemManager_ and _WorkItemConsumer_. > - Added ability to return results from consumers. > - Added ability to restart tasks if they are done. > > **Description** > - _getResults_ Fetch results from consumers. > - _drain_ wait until existing tasks are completed. > - _checkAndProduce_ add tasks only after adding to executor. > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/JsonNodeProcessManager.java > fb1e68448 > intg/src/main/java/org/apache/atlas/pc/WorkItemConsumer.java df2cb67dd > intg/src/main/java/org/apache/atlas/pc/WorkItemManager.java 8ac6f115d > intg/src/test/java/org/apache/atlas/pc/WorkItemConsumerTest.java 6c88b9e6b > intg/src/test/java/org/apache/atlas/pc/WorkItemConsumerWithResultsTest.java > PRE-CREATION > intg/src/test/java/org/apache/atlas/pc/WorkItemManagerWithResultsTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70304/diff/3/ > > > Testing > ------- > > **Unit tests** > New tests added. > > **Pre-commit Build** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/999/ > > > Thanks, > > Ashutosh Mestry > >
