-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70422/#review214476
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
Lines 430 (patched)
<https://reviews.apache.org/r/70422/#comment300686>

    Consider setting default value only if it was specified in attribute-def.
    
    lines #430 - #432:
    
     } else {
         String defaultValue = attr.getAttributeDef().getDefaultValue();
    
         if (StringUtils.isNotEmpty(defaultValue)) {
             AtlasGraphUtilsV2.setEncodedProperty(relationshipEdge, 
attrVertexProperty, attr.getAttributeType().createDefaultValue(defaultValue));
         }
     }


- Madhan Neethiraj


On April 8, 2019, 8:06 a.m., Kirankumar D G wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70422/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 8:06 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3084
>     https://issues.apache.org/jira/browse/ATLAS-3084
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> when relationships are created without setting the value for attributes, they 
> are always null. Default value should be taken from the model definition.
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  a1bdcf7b8 
> 
> 
> Diff: https://reviews.apache.org/r/70422/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kirankumar D G
> 
>

Reply via email to