-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70437/#review214504
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java
Lines 42 (patched)
<https://reviews.apache.org/r/70437/#comment300710>

    consider creating static final strings for "ConnectionStatus:", 
"Notification:", "Server:" and using it in other metrics variable values.



repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 161 (patched)
<https://reviews.apache.org/r/70437/#comment300713>

    this query requires iterating over all the vertices in the graph, consider 
using a point query - e.g. g.V().has('__type.name', '__internal')


- Sarath Subramanian


On April 9, 2019, 2:15 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70437/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 2:15 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mehul Parikh, Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3071
>     https://issues.apache.org/jira/browse/ATLAS-3071
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> updated metrics module to capture following stats for periods current-day, 
> current-hour, past-hour, past-day and since-server-start:
> - count of notifications processed
> - avg time to process a notification
> - count of entity-creates
> - count of entity-updates
> - count of entity-deletes
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/AtlasStatistics.java 0ecbd9aff 
>   intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java 
> c3304cca7 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> d9ea12af6 
>   repository/src/main/java/org/apache/atlas/util/AtlasMetricsCounter.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/util/StatisticsUtil.java 
> efb804b49 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> 78e5803f3 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  8430fd444 
>   
> webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorService.java
>  7887afb9a 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  c7ba69956 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  de316b67f 
>   
> webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java
>  0fe3ebae1 
> 
> 
> Diff: https://reviews.apache.org/r/70437/diff/2/
> 
> 
> Testing
> -------
> 
> Here is stats generated from an Atlas instance:
> 
> "stats": {
>   "ConnectionStatus:backendStore":           "connected",
>   "ConnectionStatus:indexStore":             "connected",
>   "Notification:currentDay":                       66014,
>   "Notification:currentDayAvgTime":                  700,
>   "Notification:currentDayEntityCreates":        2611470,
>   "Notification:currentDayEntityDeletes":            103,
>   "Notification:currentDayEntityUpdates":         103300,
>   "Notification:currentDayFailed":                  1450,
>   "Notification:currentDayStartTime":      1554768000000,
>   "Notification:currentHour":                          0,
>   "Notification:currentHourAvgTime":                   0,
>   "Notification:currentHourEntityCreates":             0,
>   "Notification:currentHourEntityDeletes":             0,
>   "Notification:currentHourEntityUpdates":             0,
>   "Notification:currentHourFailed":                    0,
>   "Notification:currentHourStartTime":     1554843600000,
>   "Notification:lastMessageProcessedTime": 1554843623138,
>   "Notification:offsetCurrent":                    91640,
>   "Notification:offsetStart":                          0,
>   "Notification:previousDay":                      25627,
>   "Notification:previousDayAvgTime":                 906,
>   "Notification:previousDayEntityCreates":       1381519,
>   "Notification:previousDayEntityDeletes":             0,
>   "Notification:previousDayEntityUpdates":         45190,
>   "Notification:previousDayFailed":                    0,
>   "Notification:previousHour":                         0,
>   "Notification:previousHourAvgTime":                  0,
>   "Notification:previousHourEntityCreates":            0,
>   "Notification:previousHourEntityDeletes":            0,
>   "Notification:previousHourEntityUpdates":            0,
>   "Notification:previousHourFailed":                   0,
>   "Notification:total":                            91641,
>   "Notification:totalAvgTime":                       758,
>   "Notification:totalCreates":                   3992989,
>   "Notification:totalDeletes":                       103,
>   "Notification:totalFailed":                       1450,
>   "Notification:totalUpdates":                    148490,
>   "Server:activeTimeStamp":                1554841108133,
>   "Server:startTimeStamp":                 1554841108133,
>   "Server:upTime":           "1 day 2 hour 20 min 17 sec"
> }
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to