----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70433/#review214559 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 204 (patched) <https://reviews.apache.org/r/70433/#comment300732> uniqueAttributes is a list containing unique-attributes for multiple entities; consider replacing this with entity.getGuid(). webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java Lines 593 (patched) <https://reviews.apache.org/r/70433/#comment300735> Can you please add an example of how this REST API would be called, showing the query-parameters to pass unique-attributes for multiple entities? Please refer to JavaDoc for getByUniqueAttributes() in this file. - Madhan Neethiraj On April 9, 2019, 11:12 a.m., Ayush Nigam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70433/ > ----------------------------------------------------------- > > (Updated April 9, 2019, 11:12 a.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > Signed-off-by: anigam <[email protected]> > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > a5ef34bd85b184ac8e3074b7cc415b075ebbd814 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 74c19e2e4dcbd67d2dc40f55140aef2e40ae38c6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > a74eded09fef3bf5c6ee4f7e1c8bf5b04abab853 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 4bfb4ee3f786ec5bb47ed08eba21332e0be71f11 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java > 2c21773ac68fd69fa3f1a020fa9938ddbb259fb1 > > > Diff: https://reviews.apache.org/r/70433/diff/1/ > > > Testing > ------- > > > Thanks, > > Ayush Nigam > >
