----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70475/#review214665 -----------------------------------------------------------
Ship it! Ship It! - keval bhatt On April 15, 2019, 7:01 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70475/ > ----------------------------------------------------------- > > (Updated April 15, 2019, 7:01 a.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Mehul > Parikh, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3139 > https://issues.apache.org/jira/browse/ATLAS-3139 > > > Repository: atlas > > > Description > ------- > > updated basic-search implementation to look for relationship-attributes when > a specified attribute is not directly defined in the entity-type being > searched > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 31953bdd1 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 19f81d357 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 5aa6c8f0e > > > Diff: https://reviews.apache.org/r/70475/diff/1/ > > > Testing > ------- > > - verified that basic-search results include specified attributes, both > directly defined and relationship-attributes. > - pre-commit tests run > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1033/ > > > Thanks, > > Madhan Neethiraj > >
