----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70488/#review214738 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java Lines 121 (patched) <https://reviews.apache.org/r/70488/#comment300970> Consider initializing 'manager' in line #117, and remove lines #121 to #126. This will also help to avoid having to null-check at line #137. repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java Line 204 (original), 200 (patched) <https://reviews.apache.org/r/70488/#comment300971> 'graph' can be made final as well. - Madhan Neethiraj On April 17, 2019, 8:52 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70488/ > ----------------------------------------------------------- > > (Updated April 17, 2019, 8:52 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Bugs: ATLAS-3143 > https://issues.apache.org/jira/browse/ATLAS-3143 > > > Repository: atlas > > > Description > ------- > > **Approach** > Removed short lived small objects that were taxing GC. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > 883a31bad > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java > 19ec5e4b6 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java > 51010393d > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java > 580caa535 > intg/src/main/java/org/apache/atlas/pc/WorkItemConsumer.java 8351b7ce6 > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchHandler.java > d8dcfefad > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchRegistry.java > df57959cb > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java > c5af50053 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > 662edc91b > > repository/src/test/java/org/apache/atlas/patches/AtlasPatchRegistryTest.java > 58396e5c2 > > > Diff: https://reviews.apache.org/r/70488/diff/5/ > > > Testing > ------- > > **Unit tests** > Existing. > > > Thanks, > > Ashutosh Mestry > >
